Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
50 most recent check-ins
|
2024-10-30
| ||
| 12:03 | remove extra newline Leaf check-in: e2d2c809eb user: hiltjo@codemadness.org tags: trunk, origin/master | |
| 12:02 | Avoid unsigned integer underflow in drw_text() Patch by Raymond Cole <rc@wolog.xyz>, thanks. check-in: 8ed59deda3 user: hiltjo@codemadness.org tags: trunk, origin/master | |
|
2024-10-27
| ||
| 19:08 | util.c: output function might override errno and thus affect perror() Original patch by Raymond Cole with some modifications, thanks! check-in: 106b495b4d user: hiltjo@codemadness.org tags: trunk, origin/master | |
|
2024-07-14
| ||
| 09:43 | drw.c: use the same pattern as ellipsis_width to check for infinite recursion check-in: ea09cc60f0 user: hiltjo@codemadness.org tags: trunk, origin/master | |
| 09:42 | render invalid utf8 sequences as U+FFFD previously drw_text would do the width calculations as if invalid utf8 sequences were replaced with U+FFFD but would pass the invalid utf8 sequence to xft to render where xft would just cut it off at the first invalid byte. this change makes invalid utf8 render as U+FFFD and avoids sending invalid sequences to xft. the following can be used to check the behavior before and after the patch: $ printf "0\xef1234567\ntest" | dmenu Ref: https://lists.suckless.org/dev/2407/35646.html check-in: c7c340b611 user: hiltjo@codemadness.org tags: trunk, origin/master | |
| 09:42 | overhaul utf8decode() this changes the utf8decode function to: * report when an error occurs * report how many bytes to advance on error these will be useful in the next commit to render invalid utf8 sequences. the new implementation is also shorter and more direct. check-in: 07b525d4f7 user: hiltjo@codemadness.org tags: trunk, origin/master | |
|
2024-06-24
| ||
| 09:18 | dmenu is now able to select what was input, even if a match exists (input: "text" matches: "textme" "sometext" will now also enable you to select "text") Leaf check-in: e1e3e3d13f user: brain@beanbrain.blog tags: trunk, selinput | |
| 06:23 | add debug option for make DEBUG=-g Leaf check-in: ac12dc40df user: brain@beanbrain.blog tags: trunk, bean | |
| 05:43 | added config.h to make clean check-in: 7157860db5 user: brain@beanbrain.blog tags: trunk, bean | |
|
2024-06-22
| ||
| 09:50 | refactoring... Leaf check-in: f79884a4da user: brain@beanbrain.blog tags: trunk, rubadub | |
| 09:50 | dmenu will now print the date and time of compilation in version info check-in: ad1c7a45d4 user: brain@beanbrain.blog tags: trunk, rubadub | |
| 09:49 | add config.h to make clean check-in: 90cdc62ee2 user: brain@beanbrain.blog tags: trunk, rubadub | |
| 03:46 | refactoring... check-in: 04f64e4d75 user: brain@beanbrain.blog tags: trunk, rubadub | |
|
2024-06-21
| ||
| 06:22 | improving makefile, adding cflags delinters check-in: 99151ec7ff user: brain@beanbrain.blog tags: trunk, bean | |
|
2024-06-19
| ||
| 12:46 | updated config.mk for my system/xbps & pkg-config check-in: c715d537d6 user: brain@beanbrain.blog tags: trunk, bean | |
| 12:39 | added in xresources patch (modified from xresources-alt: loads from pywal's foreground, background color* etc names) check-in: 92c873e3b8 user: brain@beanbrain.blog tags: trunk, bean | |
|
2024-03-19
| ||
| 11:12 | bump version to 5.3 Leaf check-in: f2f476a8b3 user: hiltjo@codemadness.org tags: trunk, master | |
|
2023-09-22
| ||
| 13:16 | Makefile: remove the options target The Makefile used to suppress output (by using @), so this target made sense at the time. But the Makefile should be simple and make debugging with less abstractions or fancy printing. The Makefile was made verbose and doesn't hide the build output, so remove this target. Prompted by a question on the mailing list about the options target. check-in: 8434c89fdf user: hiltjo@codemadness.org tags: trunk, master | |
|
2023-07-07
| ||
| 13:03 | drw: minor improvement to the nomatches cache 1. use `unsigned int` to store the codepoints, this avoids waste on common case where `long` is 64bits. and POSIX guarantees `int` to be at least 32bits so there's no risk of truncation. 2. since switching to `unsigned int` cuts down the memory requirement by half, double the cache size from 64 to 128. 3. instead of a linear search, use a simple hash-table for O(1) lookups. check-in: 346c90c351 user: hiltjo@codemadness.org tags: trunk, master | |
|
2023-04-06
| ||
| 18:28 | fix BadMatch error when embedding on some windows When embedded into another window, dmenu will fail with the BadMatch error if that window have not the same colormap/depth/visual as the root window. That happens because dmenu inherits the colormap/depth/visual from its parent, but draws on a pixmap created based on the root window using a GC created for the root window (see drw.c). A BadMatch will occur when copying the content of the pixmap into dmenu's window. A solution is to create dmenu's window inside root and then reparent it if embeded. See this mail[1] on ports@openbsd.org mailing list for context. [1]: https://marc.info/?l=openbsd-ports&m=168072150814664&w=2 check-in: a7c3135028 user: hiltjo@codemadness.org tags: trunk, master | |
|
2023-03-08
| ||
| 20:28 | readstdin: reduce memory-usage by duplicating the line from getline() Improves upon commit 32db2b125190d366be472ccb7cad833248696144 The getline() implementation often uses a more greedy way of allocating memory. Using this buffer directly and forcing an allocation (by setting it to NULL) would waste a bit of extra space, depending on the implementation of course. Tested on musl libc and glibc. The current glibc version allocates a minimum of 120 bytes per line. For smaller lines musl libc seems less wasteful but still wastes a few bytes per line. On a dmenu_path listing on my system the memory usage was about 350kb (old) vs 30kb (new) on Void Linux glibc. Side-note that getline() also reads NUL bytes in lines, while strdup() would read until the NUL byte. Since dmenu reads text lines either is probably fine(tm). Also rename junk to linesiz. check-in: 51ab32ba75 user: hiltjo@codemadness.org tags: trunk, master | |
|
2022-10-31
| ||
| 10:52 | readstdin: allocate amount of items Keep track of the amount of items (not a total buffer size), allocate an array of new items. For now change BUFSIZ bytes to 256 * sizeof(struct item)). check-in: 77115f7467 user: hiltjo@codemadness.org tags: trunk, master | |
| 10:46 | readstdin: add a comment Maybe too obvious / redundant, but OK. check-in: 20bfd278d2 user: hiltjo@codemadness.org tags: trunk, master | |
| 10:40 | fix leak when getline fails according to the getline(3) documentation, the calling code needs to free the buffer even if getline fails. dmenu currently doesn't do that which results in a small leak in case of failure (e.g when piped /dev/null) $ ./dmenu < /dev/null ==8201==ERROR: LeakSanitizer: detected memory leaks Direct leak of 120 byte(s) in 1 object(s) allocated from: #0 0x7f6bf5785ef7 in malloc #1 0x7f6bf538ec84 in __getdelim #2 0x405d0c in readstdin dmenu.c:557 moving `line = NULL` inside the loop body wasn't strictly necessary, but IMO it makes it more apparent that `line` is getting cleared to NULL after each successful iteration. check-in: 41cbf7a147 user: hiltjo@codemadness.org tags: trunk, master | |
|
2022-10-26
| ||
| 07:43 | dmenu: small XmbLookupString code improvements * Increase the length of composed strings to the same limit as st (32 to 64 bytes). * Initialize ksym to NoSymbol to be safe: currently this is not an issue though. * Add comments to clarify the return values of XmbLookupString a bit. check-in: 2501791a38 user: hiltjo@codemadness.org tags: trunk, master | |
|
2022-10-04
| ||
| 17:36 | bump version to 5.2 Leaf check-in: bf94e60a7b user: hiltjo@codemadness.org tags: trunk, 5.2 | |
|
2022-10-01
| ||
| 11:20 | dmenu: use die() to print the usage message check-in: f9019485aa user: hiltjo@codemadness.org tags: trunk | |
|
2022-09-17
| ||
| 13:32 | remove workaround for a crash with color emojis on some systems, now fixed in libXft 2.3.5 https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS check-in: 3fa7baaa90 user: hiltjo@codemadness.org tags: trunk | |
|
2022-09-02
| ||
| 17:09 | fix a regression in the previous commit for tab complete Reported by Santtu Lakkala <inz@inz.fi>, thanks! check-in: 869a79ba9c user: hiltjo@codemadness.org tags: trunk | |
| 11:00 | tab-complete: figure out the size before copying we already need to know the string length since `cursor` needs to be adjusted. so just calculate the length beforehand and use `memcpy` to copy exactly as much as needed (as opposed to `strncpy` which always writes `n` bytes). check-in: a0da9e3156 user: hiltjo@codemadness.org tags: trunk | |
| 10:53 | readstdin: use getline(3) currently readstdin(): - fgets() into a local buffer, - strchr() the buffer to eleminate the newline - stdups() the buffer into items a simpler way is to just use getline(3), which will do the allocation for us; eliminating the need for stdup()-ing. additionally getline returns back the amount of bytes read, which eliminates the need for strchr()-ing to find the newline. check-in: 97e278a6a6 user: hiltjo@codemadness.org tags: trunk | |
|
2022-08-08
| ||
| 08:42 | sync code-style patch from libsl check-in: fc7821403b user: hiltjo@codemadness.org tags: trunk | |
|
2022-05-01
| ||
| 16:38 | Makefile: add manual path for OpenBSD check-in: 6784eeec58 user: hiltjo@codemadness.org tags: trunk | |
|
2022-04-30
| ||
| 11:19 | fix incorrect comment, math is hard check-in: df1c45346f user: hiltjo@codemadness.org tags: trunk | |
|
2022-04-29
| ||
| 18:18 | inputw: improve correctness and startup performance, by NRK Always use ~30% of the monitor width for the input in horizontal mode. Patch adapted from NRK patches. This also does not calculate inputw when using vertical mode anymore (because the code is removed). check-in: 30127c76bc user: hiltjo@codemadness.org tags: trunk | |
|
2022-04-16
| ||
| 14:21 | drw_text: account for fallback fonts in ellipsis_width additionally, ellipsis_width (which shouldn't change) is made static to avoid re-calculating it on each drw_text() call. check-in: dd8d0d3906 user: hiltjo@codemadness.org tags: trunk | |
| 14:21 | drw_text: don't segfault when called with 0 width this patch just rejects *any* 0 width draws, which is surely an error by the caller. this also guards against cases where the width is too small for the ellipsis to fit, so ellipsis_w will remain 0. reported by Bakkeby <bakkeby@gmail.com> check-in: 502d54405d user: hiltjo@codemadness.org tags: trunk | |
|
2022-03-26
| ||
| 16:58 | fix UB with the function iscntrl() From commit 6818e07291f3b2913e687c8ec3d3fe4711724050 by NRK, thanks check-in: c1e563bd9a user: hiltjo@codemadness.org tags: trunk | |
| 16:57 | Revert "avoid redraw when there's no change" This reverts commit 6818e07291f3b2913e687c8ec3d3fe4711724050. This broke keys such as ^W to delete-backward-word check-in: 17b83eba8f user: hiltjo@codemadness.org tags: trunk | |
|
2022-03-25
| ||
| 21:53 | avoid redraw when there's no change while i was timing the performance issue, i noticed that there was lots of random redrawing going on. turns out there were coming from here; if someone presses CTRL/ALT etc without pressing anything else, nothing will be inserted, so nothing will change. but the code will `break`, go down and do a needless redraw. this patch changes it to simply return if the keypress iscntrl() also avoid potential UB by casting *buf into an unsigned char. check-in: a3663aa11c user: hiltjo@codemadness.org tags: trunk | |
| 21:53 | free all allocated items, use %zu for size_t `items` itself is not checked for NULL as calling free on NULL is defined to be a no-op. check-in: 13085e0573 user: hiltjo@codemadness.org tags: trunk | |
| 21:49 | drw_text: improve performance when there's no match this was the last piece of the puzzle, the case where we can't find any font to draw the codepoint. in such cases, we use XftFontMatch() which is INSANELY slow. but that's not the real problem. the real problem was we were continuously trying to match the same thing over and over again. this patch introduces a small cache, which keeps track a couple codepoints for which we know we won't find any matches. with this, i can dump lots of emojies into dmenu where some of them don't have any matching font, and still not have dmenu lag insanely or FREEZE completely when scrolling up and down. this also improves startup time, which will of course depend on the system and all installed fonts; but on my system and test case i see the following startup time drop: before -> after 60ms -> 34ms check-in: 346995d65a user: hiltjo@codemadness.org tags: trunk | |
| 21:49 | inputw: improve correctness and startup performance a massive amount of time inside readstdin() is spent trying to get the max input width and then put it into inputw, only for it to get clamped down to mw/3 inside setup(). it makes more sense to calculate inputw inside setup() once we have mw available. similar to the last patch, i see noticeable startup performance improvement: before -> after 160ms -> 60ms additionally this will take fallback fonts into account compared to the previous version, so it's not only more performant but also more correct. check-in: fb23dd95a9 user: hiltjo@codemadness.org tags: trunk | |
| 21:49 | significantly improve performance on large strings this replaces inefficient pattern of `MIN(TEXTW(..), n)` with drw_fontset_getwidth_clamp() instead, which is far more efficient when we only want up to a certain width. dumping a decently sized (unicode) emoji file into dmenu, I see the startup time drop significantly with this patch. before -> after 360ms -> 160ms this should also noticeably improve input latency (responsiveness) given that calcoffsets() and drawmenu() are pretty hot functions. check-in: dac19f4ad6 user: hiltjo@codemadness.org tags: trunk | |
| 21:49 | introduce drw_fontset_getwidth_clamp() getting the width of a string is an O(n) operation, and in many cases users only care about getting the width upto a certain number. instead of calling drw_fontset_getwidth() and *then* clamping the result, this patch introduces drw_fontset_getwidth_clamp() function, similar to strnlen(), which will stop once we reach n. the `invert` parameter was overloaded internally to preserve the API, however library users should be calling drw_fontset_getwidth_clamp() and not depend upon internal behavior of drw_text(). check-in: 4754183d95 user: hiltjo@codemadness.org tags: trunk | |
| 21:49 | drw_text: improve both performance and correctness this patch makes some non-trivial changes, which significantly improves the performance of drawing large strings as well as fixes any issues regarding the printing of the ellipsis when string gets truncated. * performance: before there were two O(n) loops, one which finds how long we can go without changing font, and the second loop would (incorrectly) truncate the string if it's too big. this patch merges the overflow calculation into the first loop and exits out when overflow is detected. when dumping lots of emojies into dmenu, i see some noticeable startup time improvement: before -> after 460ms -> 360ms input latency when scrolling up/down is also noticeably better and can be tested with the following: for _ in $(seq 20); do cat /dev/urandom | base64 | tr -d '\n' | head -c 1000000 echo done | ./dmenu -l 10 * correctness: the previous version would incorrectly assumed single byte chars and would overwrite them with '.' , this caused a whole bunch of obvious problems, including the ellipsis not getting rendered if then font changed. in addition to exiting out when we detect overflow, this patch also keeps track of the last x-position where the ellipsis would fit. if we detect overflow, we simply make a recursing call to drw_text() at the ellipsis_x position and overwrite what was there. so now the ellipsis will always be printed properly, regardless of weather the font changes or if the string is single byte char or not. the idea of rendering the ellipsis on top incase of overflow was from Bakkeby <bakkeby@gmail.com>, thanks! however the original patch had some issues incorrectly truncating the prompt (-p flag) and cutting off emojies. those have been fixed in here. check-in: 167bb99c40 user: hiltjo@codemadness.org tags: trunk | |
|
2022-03-01
| ||
| 21:45 | remove false-positive warning for int comparison as bool Reported by Prathu Baronia <prathu.baronia@praton.me>, patch slightly changed. Thanks! check-in: 56beb72dec user: hiltjo@codemadness.org tags: trunk | |
|
2022-02-11
| ||
| 11:26 | bump version to 5.1 check-in: 63fe5a1252 user: hiltjo@codemadness.org tags: trunk, 5.1 | |
|
2022-02-08
| ||
| 20:45 | code-style: rm newline (oops) check-in: 1609ba0409 user: hiltjo@codemadness.org tags: trunk | |
| 18:38 | revert using strcasestr and use a more optimized portable version ... compared to the old cistrstr(). Thanks for the feedback! check-in: b4d7d3d1b4 user: hiltjo@codemadness.org tags: trunk | |