Login
Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 most recent check-ins

2025-03-02
06:59
Merge branch 'master' of https://git.suckless.org/st into bean Leaf check-in: 8133db3456 user: brain@beanbrain.blog tags: trunk, refs/stash, bean
06:58
added sixel support via libsixel from https://gist.github.com/CommandMaker/27ba97427424c06aff54d0a2a91a4ef1#file-8-sixel-patch check-in: 48b7d0c2a7 user: brain@beanbrain.blog tags: trunk, refs/stash, bean
2025-01-30
16:50
Do not interpret CSI ? u as DECRC The kitty keyboard protocol docs recommend CSI ? u to query support for that protocol, see https://sw.kovidgoyal.net/kitty/keyboard-protocol/ For better or worse, fish shell uses this query to work around bugs in other terminals triggered by requesting that protocol via CSI = 5 u. Unfortunately, st interprets CSI ? u as DECRC (restore cursor position). reproduce with 'printf "\x1b[?u"; cat'. fish could work around this by switching to the alternate screen before running this query; but that might cause tearing on terminals that don't support Synchronized Output. I'm not sure. In the meantime, let's correct our parser. This adds a redundant else-after-return, for consistency with the surrounding code. Leaf check-in: 5f14024ff9 user: hiltjo@codemadness.org tags: trunk, refs/stash, origin/master
2024-12-06
12:42
Clear screen: Fix edge case With sequence \e[1J, if cursor is on second line, clear the first line. check-in: 4b193ff4d8 user: hiltjo@codemadness.org tags: trunk, refs/stash, origin/master
2024-08-17
17:02
font => iosevka check-in: 6fe4a6970b user: brain@beanbrain.blog tags: trunk, refs/stash, bean
16:59
update to upstream Merge branch 'master' of https://git.suckless.org/st into bean check-in: 45f337563c user: brain@beanbrain.blog tags: trunk, refs/stash, bean
2024-08-09
11:34
fix BadMatch error when embedding on some windows When embedded, st fails with BadMatch error if the embedder's window has non-default colormap/depth/visual. This commit fixes that by creating st's window inside root and then reparent it into embedder. The reference window for dc.gc is also changed to match root's visuals. A similar commit had been made for dmenu[1]. See this issue[2] on github for context. [1]: https://git.suckless.org/dmenu/commit/0fe460dbd469a1d5b6a7140d0e1801935e4a923b.html [2]: https://github.com/phillbush/xfiles/issues/47 check-in: 95deed0978 user: hiltjo@codemadness.org tags: trunk, refs/stash, origin/master
2024-06-25
15:09
a nice border check-in: a0c560985a user: brain@beanbrain.blog tags: trunk, refs/stash, bean
07:46
clean cleans config.h check-in: 1454796122 user: brain@beanbrain.blog tags: trunk, refs/stash, bean
07:18
fix prefix no longer using /bin/stow check-in: c99b8654fc user: brain@beanbrain.blog tags: trunk, refs/stash, bean
2024-06-19
11:17
configs: fira code, shell, bin path... check-in: 422a57b6c5 user: brain@beanbrain.blog tags: trunk, refs/stash, bean
2024-05-01
18:45
support colons in SGR character attributes Patch by Mikhail Kot <to@myrrc.dev> With some modifications to behave more like xterm (see note below). Example: printf '\033[48;2;255:0:0mtest\n' https://invisible-island.net/xterm/ctlseqs/ctlseqs.html Some notes: "CSI Pm m Character Attributes (SGR). [...] o xterm allows either colons (standard) or semicolons (legacy) to separate the subparameters (but after the first colon, colons must be used). Leaf check-in: 94e70ba5be user: hiltjo@codemadness.org tags: trunk, refs/stash, master
2024-04-26
07:51
WIP on master: 9846a56 Add terminfo entries for bracketed paste mode Leaf check-in: c81ec74504 user: v.delaney@proton.me tags: trunk, refs/stash
07:51
index on master: 9846a56 Add terminfo entries for bracketed paste mode check-in: d10e2a28c1 user: v.delaney@proton.me tags: trunk, refs/stash
2024-04-05
10:18
bump version to 0.9.2 Leaf check-in: ae84df1edf user: hiltjo@codemadness.org tags: trunk, refs/stash, 0.9.2
2024-04-03
17:49
Reset title when an empty title string is given With this patch, st will reset its window title when an empty string is given as the terminal title. For example: printf "\033]0;\007" Some applications, like termdown, expect this functionality. xterm implements it, but it seems that most other terminal emulators don't. In any case, I don't see why there should ever be a case where the st window doesn't have a title property. check-in: 944c0620c4 user: hiltjo@codemadness.org tags: trunk, refs/stash
2024-03-30
11:37
Revert "Fix cursor move with wide glyphs" This reverts commit 7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5. This patch needs some more work. It caused regressions with programs that use GNU readline, etc. Original test-case example from Tim Culverhouse <tim@timculverhouse.com>: printf " 😀" && sleep 2 && printf "\e[D" && sleep 2 && printf "\e[D" && sleep 2 After the patch it caused regressions, example test-case: printf "A字\bB\n" check-in: c626f1ebdb user: hiltjo@codemadness.org tags: trunk, refs/stash
2024-03-19
11:13
bump version to 0.9.1 check-in: 35465ef398 user: hiltjo@codemadness.org tags: trunk, refs/stash, 0.9.1
2024-03-17
13:42
config.def.h: improve latency for the default configuration check-in: cda59af04c user: hiltjo@codemadness.org tags: trunk, refs/stash
2024-03-04
22:50
set upper limit for REP escape sequence argument Previously, printf 'L\033[2147483647b' would call tputc('L') 2^31 times, making st unresponsive. This commit allows repeating the last character at most 65535 times in order to prevent freezing and DoS attacks. check-in: ac3ac1946b user: hiltjo@codemadness.org tags: trunk, refs/stash
2024-02-25
10:56
Fix cursor move with wide glyphs st would always move back 1 column, even with wide glyhps (using more than a single column). The glyph rune is set on its first column, and the other ones are to 0, so loop until we detect the start of the previous glyph. check-in: d7760feecf user: hiltjo@codemadness.org tags: trunk, refs/stash
2024-02-18
15:14
csi: check for private marker in 'S' case The handler for 'S' final character does not check for a private marker. This can cause a conflict with a sequence called 'XTSMGRAPHICS' which also has an 'S' final character, but uses the private marker '?'. Without checking for a private marker, st will perform a scroll up operation when XTSMGRAPHICS is seen, which can cause unexpected display artifacts. check-in: 5c5c1396d4 user: hiltjo@codemadness.org tags: trunk, refs/stash
2023-10-07
10:16
Add terminfo entries for bracketed paste mode Helps Vim (and hopefully others) to discover that this feature exists without further user configuration. check-in: 7c4dbd802c user: hiltjo@codemadness.org tags: trunk, refs/stash
10:16
Unhide cursor on RIS (\033c) It is unclear if it's "required" to do this on RIS, but it's useful when calling reset(1) after interactive programs have crashed and garbled up the screen. FWIW, other terminals do it as well (tested with XTerm, VTE, Kitty, Alacritty, Linux VT). check-in: 189bed2537 user: hiltjo@codemadness.org tags: trunk, refs/stash
10:16
Fix wide glyphs breaking "nowrap" mode Consider the following example: printf '\e[?7l';\ for i in $(seq $(($(tput cols) - 1))); do printf a; done;\ printf '🙈\n';\ printf '\e[?7h' Even though MODE_WRAP has been disabled, the emoji appeared on the next line. This patch keeps wide glyphs on the same line and moves them to the right-most possible position. check-in: 681e680f4b user: hiltjo@codemadness.org tags: trunk, refs/stash
10:16
Don't scroll selection on the other screen Fixes garbage selections when switching to/from the alternate screen. How to reproduce: - Be in primary screen. - Select something. - Run this (switches to alternate screen, positions the cursor at the bottom, triggers selscroll(), and then goes back to primary screen): tput smcup; tput cup $(tput lines) 0; echo foo; tput rmcup - Notice how the (visual) selection now covers a different line. The reason is that selscroll() calls selnormalize() and that cannot find the original range anymore. It's all empty lines now, so it snaps to "select the whole line". check-in: 0491386567 user: hiltjo@codemadness.org tags: trunk, refs/stash
10:16
Fix bounds checks of dc.col dc.collen is the length of dc.col, not the maximum index, hence if x is equal to dc.collen, then it's an error. With config.def.h, the last valid index is 259, so this correctly reports "black": $ printf '\033]4;259;?\e\\' 260 is an invalid index and this reports garbage instead of printing an error: $ printf '\033]4;260;?\e\\' check-in: 93e25ace55 user: hiltjo@codemadness.org tags: trunk, refs/stash
2023-09-22
13:16
Makefile: remove the options target The Makefile used to suppress output (by using @), so this target made sense at the time. But the Makefile should be simple and make debugging with less abstractions or fancy printing. The Makefile was made verbose and doesn't hide the build output, so remove this target. Prompted by a question on the mailing list about the options target. check-in: d703ed94de user: hiltjo@codemadness.org tags: trunk, refs/stash
2023-06-25
09:59
Fix for wide character being incorrectly cleared on MODE_INSERT Under insert mode, when inserting a normal character in front of a wide character, the affected region is shifted to the right by one cell. However, the empty cell is reset as if being a part of a wide character, causing the following cell being mishandled as a dummy cell. To reproduce the bug: printf '\033[4h' # set MODE_INSERT printf 妳好 printf '\033[4D' printf 'x' printf '\033[4l\n' check-in: af8191e993 user: hiltjo@codemadness.org tags: trunk, refs/stash
2023-02-07
19:00
ignore C1 control characters in UTF-8 mode Ignore processing and printing C1 control characters in UTF-8 mode. These are in the range: 0x80 - 0x9f. By default in st the mode is set to UTF-8. This matches more the behaviour of xterm with the options -u8 or +u8 also. Also see the xterm resource "allowC1Printable". Let me know if this breaks something, in most cases I don't think so. As usual a very good reference is: https://invisible-island.net/xterm/ctlseqs/ctlseqs.html check-in: 1330228318 user: hiltjo@codemadness.org tags: trunk, refs/stash
18:57
Add support for DSR response "OK" escape sequence "VT100 defines an escape sequence [1] called Device Status Report (DSR). When the DSR sequence received is `csi 5n`, an "OK" response `csi 0n` is returned. This patch adds that "OK" response. I encountered this missing sequence when I noticed that fzf [2] would clobber my prompt whenever completing a find. To test that ST doesn't currently respond to `csi 5n`, use fzf's shell extension in ST's repo to complete the path for a file. my-fancy-prompt $ vim **<tab> <select a file> st.c Select a file with <enter>, and notice that fzf clobbers some or all of your prompt. After applying this patch, do the same test as above and notice that fzf has no longer clobbered your prompt by placing the file name in the correct position in your command. my-fancy-prompt $ vim **<tab> <select a file> my-fancy prompt $ vim st.c Thank you for considering my first patch submission. [1] https://www.xfree86.org/current/ctlseqs.html#VT100%20Mode [2] https://github.com/junegunn/fzf " Patch slightly adapted with input from the mailinglist, check-in: 7288590308 user: hiltjo@codemadness.org tags: trunk, refs/stash
2023-02-05
12:29
Fixed OSC color reset without parameter->resets all colors Adapted from (garbled) patch by wim <wim@thinkerwim.org> Additional notes: it should reset all the colors using xloadcols(). To reproduce: set a different (theme) color using some escape code, then reset it: printf '\x1b]104\x07' check-in: a99a8888e8 user: hiltjo@codemadness.org tags: trunk, refs/stash
2022-10-25
15:11
fix buffer overflow when handling long composed input To reproduce the issue: " If you already have the multi-key enabled on your system, then add this line to your ~/.XCompose file: [...] <question> <T> <E> <S> <T> <question> : "1234567890123456789012345678901234567890123456789012345678901234567890" " Reported by and an initial patch by Andy Gozas <andy@gozas.me>, thanks! Adapted the patch, for now st (like dmenu) handles a fixed amount of composed characters, or otherwise ignores it. This is done for simplicity sake. check-in: c73bcb91ad user: hiltjo@codemadness.org tags: trunk, refs/stash
2022-10-04
17:40
bump version to 0.9 Leaf check-in: 8003dd98f7 user: hiltjo@codemadness.org tags: trunk, 0.9
2022-09-16
21:07
FAQ: document the color emojis crash issue which affected some systems is fixed It is fixed in libXft 2.3.6: https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS check-in: 82617699aa user: hiltjo@codemadness.org tags: trunk
2022-08-18
15:14
st: use `void' to indicate an empty parameter list check-in: e8f52a99ee user: hiltjo@codemadness.org tags: trunk
2022-05-01
16:38
Makefile: add manual path for OpenBSD check-in: 4eaac6db99 user: hiltjo@codemadness.org tags: trunk
2022-04-19
09:43
code-golfing: cleanup osc color related code * adds missing function prototype * move xgetcolor() prototype to win.h (that's where all the other x.c func prototype seems to be declared at) * check for snprintf error/truncation * reduces code duplication for osc 10/11/12 * unify osc_color_response() and osc4_color_response() into a single function the latter two was suggested by Quentin Rameau in his patch review on the hackers list. check-in: f5e9f62de9 user: hiltjo@codemadness.org tags: trunk
2022-03-18
11:20
base64_digits: reduce scope, implicit zero, +1 size the array is not accessed outside of base64dec() so it makes sense to limit it's scope to the related function. the static-storage duration of the array is kept intact. this also removes unnecessary explicit zeroing from the start and end of the array. anything that wasn't explicitly zero-ed will now be implicitly zero-ed instead. the validity of the new array can be easily confirmed via running this trivial loop: for (int i = 0; i < 255; ++i) assert(base64_digits[i] == base64_digits_old[i]); lastly, as pointed out by Roberto, the array needs to have 256 elements in order to able access it as any unsigned char as an index; the previous array had 255. however, this array will only be accessed at indexes which are isprint() || '=' (see `base64dec_getc()`), so reducing the size of the array to the highest printable ascii char (127 AFAIK) + 1 might also be a valid strategy. check-in: 28656a1d14 user: hiltjo@codemadness.org tags: trunk
11:11
avoid potential UB when using isprint() all the ctype.h functions' argument must be representable as an unsigned char or as EOF, otherwise the behavior is undefined. check-in: 8fa5a08a39 user: hiltjo@codemadness.org tags: trunk
2022-03-13
09:45
make underlines and strikethroughs respect `chscale` check-in: 552195bfe5 user: hiltjo@codemadness.org tags: trunk
2022-02-18
12:03
Delay redrawals on palette changes Build on auto-sync and only mark window dirty on palette changes and let the event handler do the actual draw. check-in: c2e8d5239e user: hiltjo@codemadness.org tags: trunk
2022-01-12
08:44
X10/SGR mouse: use alt as meta key instead of super/windows key check-in: 0b60cb2405 user: hiltjo@codemadness.org tags: trunk
2022-01-10
16:11
LICENSE: bump year check-in: 98e267547f user: hiltjo@codemadness.org tags: trunk
16:04
Fix mousereport This patch replaces the previous one I sent. The following changes are made in this patch: - Fix tracking of pressed buttons. Previously, pressing two buttons and then releasing one would make st think no buttons are pressed, which in particular broke MODE_MOUSEMOTION. - Always send the lowest-numbered pressed button on motion events; when no button is pressed for a motion event in MODE_MOUSEMANY, then send a release. This matches the behaviour of xterm. (Previously, st sent the most recently pressed button in the motion report.) - Remove UB (?) access to potentially inactive struct member e->xbutton.button of XEvent union. - Fix (unlikely) possibility of overflow for large button numbers. The one discrepancy I found between st and xterm is that xterm sometimes encodes buttons with large numbers (>5) strangely. E.g., xterm reports presses of buttons 8 and 9 as releases, whereas st properly (?) encodes them as presses. check-in: 40fdd18788 user: hiltjo@codemadness.org tags: trunk
2022-01-07
11:39
bump version to 0.8.5 check-in: 63daed02f1 user: hiltjo@codemadness.org tags: trunk, 0.8.5
2022-01-02
11:16
FAQ: fix a typo, patch -> path check-in: 662fb35bcc user: hiltjo@codemadness.org tags: trunk
2021-12-30
17:37
Fix overtyping wide characters. Overtyping the first half of a wide character with the second half of a wide character results in display garbage. This is because the trailing dummy is not cleaned up. i.e. ATTR_WIDE, ATTR_WDUMMY, ATTR_WDUMMY Here is a short script for demonstrating the behavior: #!/bin/sh alias printf=/usr/bin/printf printf こんにちは!; sleep 2 printf '\x1b[5D'; sleep 2 printf へ; sleep 2 printf ' '; sleep 2 echo check-in: 6d1b298b95 user: hiltjo@codemadness.org tags: trunk
2021-12-27
12:07
Fix null pointer access in strhandle According to the spec the argument is optional for 104, so p can be NULL as can be tested with printf '\x1b]104\x07'. This is a regression of 8e31030. check-in: ac3d7c9c66 user: hiltjo@codemadness.org tags: trunk
2021-12-26
18:00
follow-up fix for OSC color sequences, return Otherwise the message "erresc: unknown str" is printed. check-in: ea69e06030 user: hiltjo@codemadness.org tags: trunk